Disable rust-analyzer tests on LLVM 21#156655
Open
ehuss wants to merge 1 commit into
Open
Conversation
The rust-analyzer tests have been frequently failing with a SIGSEGV on CI in the LLVM 21 runners. In my investigation, this seems to be fixed with LLVM 22. It was suggested that we should just disable these tests. There wasn't a particularly convenient way to detect if this is running with LLVM 21, so I decided to just check the CI_JOB_NAME which contains the image name which in our case includes the string "llvm-21". Fixes rust-lang#156460
rustbot
added
A-CI
Collaborator
|
r? @marcoieni rustbot has assigned @marcoieni. Use Why was this reviewer chosen?The reviewer was selected based on:
|
ehuss
added
the
beta-nominated
Contributor
Author
|
Nominating for beta since this occurs fairly often and can be difficult to get CI passing. |
JonathanBrouwer
approved these changes
May 17, 2026
Member
|
@bors r=JonathanBrouwer,jieyouxu rollup=never p=5 (let's not roll this up) |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 17, 2026
…anBrouwer,jieyouxu Disable rust-analyzer tests on LLVM 21 The rust-analyzer tests have been frequently failing with a SIGSEGV on CI in the LLVM 21 runners. In my investigation, this seems to be fixed with LLVM 22. It was suggested that we should just disable these tests. There wasn't a particularly convenient way to detect if this is running with LLVM 21, so I decided to just check the CI_JOB_NAME which contains the image name which in our case includes the string "llvm-21". Fixes #156460
Contributor
|
@bors yield |
Contributor
|
Auto build was cancelled. Cancelled workflows: The next pull request likely to be tested is #156625. |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 17, 2026
…anBrouwer,jieyouxu Disable rust-analyzer tests on LLVM 21 The rust-analyzer tests have been frequently failing with a SIGSEGV on CI in the LLVM 21 runners. In my investigation, this seems to be fixed with LLVM 22. It was suggested that we should just disable these tests. There wasn't a particularly convenient way to detect if this is running with LLVM 21, so I decided to just check the CI_JOB_NAME which contains the image name which in our case includes the string "llvm-21". Fixes #156460
Contributor
I don't think whatever change caused this issue is in beta, so imo this is not needed (but also can't hurt) |
Member
|
Consider this beta-accepted if needed, is also fine. |
Contributor
Author
|
You're right. I think we've now determined with high confidence that this was caused by #155473 which is not in beta. I'll go ahead and remove the nomination. |
ehuss
removed
the
beta-nominated
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
rust-bors
Bot
added
S-waiting-on-review
Contributor
|
💔 Test for 3e63dd9 failed: CI. Failed job:
|
Contributor
|
Another spurious failure, huray. Hope we don't see that one more often |
rust-bors
Bot
added
S-waiting-on-bors
Contributor
|
⌛ Testing commit 5c66632 with merge 507271b... Workflow: https://github.com/rust-lang/rust/actions/runs/26000045997 |
rust-bors Bot
pushed a commit
that referenced
this pull request
May 17, 2026
…anBrouwer,jieyouxu Disable rust-analyzer tests on LLVM 21 The rust-analyzer tests have been frequently failing with a SIGSEGV on CI in the LLVM 21 runners. In my investigation, this seems to be fixed with LLVM 22. It was suggested that we should just disable these tests. There wasn't a particularly convenient way to detect if this is running with LLVM 21, so I decided to just check the CI_JOB_NAME which contains the image name which in our case includes the string "llvm-21". Fixes #156460
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rust-analyzer tests have been frequently failing with a SIGSEGV on CI in the LLVM 21 runners. In my investigation, this seems to be fixed with LLVM 22. It was suggested that we should just disable these tests.
There wasn't a particularly convenient way to detect if this is running with LLVM 21, so I decided to just check the CI_JOB_NAME which contains the image name which in our case includes the string "llvm-21".
Fixes #156460