Skip to content

feat(compliance): add resource metadata tab inside req find#11187

Open
pedrooot wants to merge 3 commits into
masterfrom
PROWLER-1744-add-metadata-tab-in-compliance-requirement-findings-view-ui
Open

feat(compliance): add resource metadata tab inside req find#11187
pedrooot wants to merge 3 commits into
masterfrom
PROWLER-1744-add-metadata-tab-in-compliance-requirement-findings-view-ui

Conversation

@pedrooot
Copy link
Copy Markdown
Member

@pedrooot pedrooot commented May 15, 2026

Description

Screen.Recording.2026-05-15.at.13.38.52.mov

This pull request introduces several improvements to both backend and frontend code, primarily focused on enhancing the handling and exposure of resource metadata and details in findings, as well as refactoring test assertions for better clarity and consistency. The most important changes are summarized below.

Backend: Resource metadata and details exposure

  • api/v1/serializers.py: Added the metadata field to the ResourceSerializer's fields and set it as read-only, ensuring resource metadata is included in API responses.
  • test_views.py: Added a new test (test_findings_retrieve_include_resource_metadata) to verify that resource metadata and details are correctly included in the findings API response.

Frontend: Resource metadata and details support

Testing and code quality improvements

These changes improve the API's expressiveness, ensure the UI can display additional resource context, and make the codebase more maintainable.

Steps to review

Please add a detailed description of how to review this PR.

Checklist

Community Checklist
  • This feature/issue is listed in here or roadmap.prowler.com
  • Is it assigned to me, if not, request it via the issue/feature in here or Prowler Community Slack

SDK/CLI

  • Are there new checks included in this PR? Yes / No
    • If so, do we need to update permissions for the provider? Please review this carefully.

UI

  • All issue/task requirements work as expected on the UI
  • If this PR adds or updates npm dependencies, include package-health evidence (maintenance, popularity, known vulnerabilities, license, release age) and explain why existing/native alternatives are insufficient.
  • Screenshots/Video of the functionality flow (if applicable) - Mobile (X < 640px)
  • Screenshots/Video of the functionality flow (if applicable) - Table (640px > X < 1024px)
  • Screenshots/Video of the functionality flow (if applicable) - Desktop (X > 1024px)
  • Ensure new entries are added to CHANGELOG.md, if applicable.

API

  • All issue/task requirements work as expected on the API
  • Endpoint response output (if applicable)
  • EXPLAIN ANALYZE output for new/modified queries or indexes (if applicable)
  • Performance test results (if applicable)
  • Any other relevant evidence of the implementation (if applicable)
  • Verify if API specs need to be regenerated.
  • Check if version updates are required (e.g., specs, uv, etc.).
  • Ensure new entries are added to CHANGELOG.md, if applicable.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

✅ All necessary CHANGELOG.md files have been updated.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Conflict Markers Resolved

All conflict markers have been successfully resolved in this pull request.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

🔒 osv-scanner: 4 finding(s) in api/uv.lock

Severity gate: HIGH,CRITICAL,UNKNOWN

Severity ID Package Version Summary
🟠 HIGH (7.5) GHSA-vfmq-68hx-4jfw PyPI/lxml 5.3.2 lxml: Default configuration of iterparse() and ETCompatXMLParser() allows XXE to local files
🟠 HIGH (7) GHSA-7j59-v9qr-6fq9 PyPI/microsoft-kiota-http 1.9.2 Kiota abstractions RedirectHandler leaks Cookie/Proxy-Authorization headers on cross-host redirect
🟠 HIGH (8.9) GHSA-mf9v-mfxr-j63j PyPI/urllib3 2.6.3 urllib3: Decompression-bomb safeguards bypassed in parts of the streaming API
🟠 HIGH (8.2) GHSA-qccp-gfcp-xxvc PyPI/urllib3 2.6.3 urllib3: Sensitive headers forwarded across origins in proxied low-level redirects

To accept a finding, add an [[IgnoredVulns]] entry to osv-scanner.toml at the repo root with a reason and ignoreUntil.

View run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

🔒 Container Security Scan

Image: prowler-ui:da8765a
Last scan: 2026-05-15 11:49:01 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 2
Total 2

2 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

🔒 Container Security Scan

Image: prowler-api:da8765a
Last scan: 2026-05-15 11:48:15 UTC

📊 Vulnerability Summary

Severity Count
🔴 Critical 15
Total 15

9 package(s) affected

⚠️ Action Required

Critical severity vulnerabilities detected. These should be addressed before merging:

  • Review the detailed scan results
  • Update affected packages to patched versions
  • Consider using a different base image if updates are unavailable

📋 Resources:

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (3410fc9) to head (666be8c).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11187   +/-   ##
=======================================
  Coverage   93.65%   93.65%           
=======================================
  Files         232      232           
  Lines       33968    33979   +11     
=======================================
+ Hits        31813    31824   +11     
  Misses       2155     2155           
Flag Coverage Δ
api 93.65% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler ∅ <ø> (∅)
api 93.65% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant