feat(m365): add check for directory sync object takeover protection#11098
Open
PrettyFox0 wants to merge 2 commits into
Open
feat(m365): add check for directory sync object takeover protection#11098PrettyFox0 wants to merge 2 commits into
PrettyFox0 wants to merge 2 commits into
Conversation
Adds entra_app_registration_no_password_credentials check that flags application registrations with client secrets. Apps should authenticate using certificates, federated identity credentials, or managed identities. - Added _get_app_registrations to entra_service.py - Added AppRegistration and PasswordCredential models - Check reports FAIL for any app with passwordCredentials entries - Includes metadata and 5 test cases Closes prowler-cloud#11064 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Adds entra_directory_sync_object_takeover_blocked check that verifies both blockSoftMatchEnabled and blockCloudObjectTakeoverThroughHardMatchEnabled are enabled on the on-premises directory synchronization configuration. Without these blocks, an attacker with write access to on-premises AD can craft objects that match privileged cloud accounts and take them over. - Extended DirectorySyncSettings model with two new boolean fields - Extended _get_directory_sync_settings to fetch the new feature flags - 6 test cases covering both-enabled, each-disabled, both-disabled, cloud-only tenant, and permission errors Closes prowler-cloud#11068 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
provider/m365
Contributor
|
✅ Conflict Markers Resolved All conflict markers have been successfully resolved in this pull request. |
danibarranqueroo
added
the
status/waiting-for-revision
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entra_directory_sync_object_takeover_blockedcheck that verifies bothblockSoftMatchEnabledandblockCloudObjectTakeoverThroughHardMatchEnabledare enabledDirectorySyncSettingsmodel and_get_directory_sync_settingsto fetch the two feature flagsChanges
entra_service.py: Addedblock_soft_match_enabledandblock_cloud_object_takeover_through_hard_match_enabledtoDirectorySyncSettingsmodel and fetch logic__init__.pyTest plan
Closes #11068
🤖 Generated with Claude Code