Browser: Fix 'Tool ran without output or errors' for Agent Host image-returning client tools#316847
Draft
jruales wants to merge 2 commits into
Draft
Browser: Fix 'Tool ran without output or errors' for Agent Host image-returning client tools#316847jruales wants to merge 2 commits into
jruales wants to merge 2 commits into
Conversation
jruales
changed the title
jruales
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Agent Host client tool result conversion so image-only tool outputs, such as browser screenshots, provide a non-empty LLM text result instead of being treated as having no output.
Changes:
- Detects image embedded-resource results in client tool completions.
- Adds a fallback text result when a successful tool call returns images but no text.
Show a summary per file
| File | Description |
|---|---|
src/vs/platform/agentHost/node/copilot/copilotAgentSession.ts |
Adds image-result fallback text when completing client tool calls. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.