Re-reveal reference selection in peek preview on repeat tree click#316833
Draft
Copilot wants to merge 2 commits into
Draft
Re-reveal reference selection in peek preview on repeat tree click#316833Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Co-authored-by: dmitrivMS <9581278+dmitrivMS@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ref tree item in zone widget for repeat clicks
Re-reveal reference selection in peek preview on repeat tree click
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the Go to References zone widget, clicking an already-selected item in the references tree was a no-op. If the user had scrolled the preview editor away from the highlighted reference, there was no way to bring it back into view short of selecting a different reference first.
Changes
referencesWidget.ts— InReferenceWidget._revealReference, the early-return onthis._revealedReference === referencepreviously short-circuited all work. It now re-applies the selection and re-centers the range in the preview editor on repeat clicks, while still skipping the expensive work (model resolution, title update, tree reveal) since that state is already correct.The new path mirrors the existing first-reveal logic (
setSelection+revealRangeInCenter) and usesScrollType.Smoothsince the preview model is unchanged.