[stealth 06/11] Add garble obfuscation targets#8780
Open
reflog wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an opt-in build path to obfuscate Go/native outputs using garble, covering Android gomobile bind, Linux shared libs, desktop FFI shared libs, and lanternd, with CI support and documentation aimed at stealth/reproducible builds.
Changes:
- Introduces a
scripts/garble-go/gowrapper to route onlygo build(invoked bygomobile) throughgarble. - Extends the Makefile with
*-obfuscatedtargets, seed/garble validation helpers, and aninstall-garbletarget. - Updates the Android reusable workflow to optionally install garble and build obfuscated Android artifacts, plus adds a new stealth garble doc.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
scripts/garble-go/go |
Adds a go wrapper that runs garble ... build only for go build calls (for gomobile internal builds). |
Makefile |
Adds garble configuration variables, validation targets, and obfuscated build targets for desktop, Linux, lanternd, and Android. |
docs/stealth-go-garble.md |
Documents how to use the new obfuscated targets and the ABI/support constraints around garble. |
.github/workflows/build-android.yml |
Adds an obfuscate_go input to install garble and run the obfuscated Android release build in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
11 tasks
Contributor
Author
|
@copilot review |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8768
Validation
make check-garble-seed GARBLE_SEED=randommake -n android-release-ci-obfuscated ANDROID_SDK_ROOT=/tmp/android-sdk GARBLE_SEED=randomgit diff --cached --checkbefore commitNot run