Fix password manager autofill for Pro auth fields#8742
Open
atavism wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves Flutter Pro authentication UX by adding autofill configuration so password managers can better detect email/password fields, offer saved credentials, and suggest/generated passwords during creation/reset flows.
Changes:
- Added
AutofillGroup,autofillHints, and password-friendly keyboard/suggestion settings to sign-in password, create password, and reset password screens; finish autofill context on success. - Expanded email fields’ autofill hints (email + username) and set appropriate input types/actions where missing.
- Minor cleanup/formatting and added a few
mountedguards around async UI updates.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lib/features/auth/sign_in_password.dart | Wraps password entry in AutofillGroup, adds password field settings, and calls TextInput.finishAutofillContext on successful sign-in. |
| lib/features/auth/sign_in_email.dart | Adds username autofill hint alongside email for better credential detection. |
| lib/features/auth/reset_password.dart | Adds AutofillGroup + newPassword hints and finishes autofill context after successful reset. |
| lib/features/auth/reset_password_email.dart | Improves email field input type/action and adds email/username autofill hints. |
| lib/features/auth/create_password.dart | Adds AutofillGroup + newPassword hints, finishes autofill context after success, and adds context.mounted checks. |
| lib/features/auth/add_email.dart | Adds email/username autofill hints to the email field, removes an unused import, and adds mounted checks around async UI work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
myleshorton
approved these changes
May 12, 2026
Contributor
|
Were you able to verify it works @atavism? |
jigar-f
reviewed
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/getlantern/engineering/issues/3048
Adds proper autofill hints and autofill groups to Pro email, sign-in, password creation, and reset flows so password managers like 1Password and iCloud Keychain can detect credentials, suggest generated passwords, etc.