Fix UB when emiting warning for empty contracts with custom layout near the end of storage#16682
Open
matheusaaguiar wants to merge 2 commits into
Open
Fix UB when emiting warning for empty contracts with custom layout near the end of storage#16682matheusaaguiar wants to merge 2 commits into
matheusaaguiar wants to merge 2 commits into
Conversation
matheusaaguiar
force-pushed
the
fix_custom_storage_layout_warning_UB
branch
from
5988dfb to
2f481bc
Compare
msooseth
previously approved these changes
May 7, 2026
Contributor
msooseth
left a comment
msooseth
left a comment
There was a problem hiding this comment.
LGTM, but I am bad at reviews.
matheusaaguiar
force-pushed
the
fix_custom_storage_layout_warning_UB
branch
from
2f481bc to
263706a
Compare
matheusaaguiar
commented
May 7, 2026
| for (ContractDefinition const* baseContract: ranges::actions::reverse(_contract.annotation().linearizedBaseContracts)) | ||
| for (VariableDeclaration const* stateVariable: ranges::actions::reverse(baseContract->stateVariables())) | ||
| if (stateVariable->referenceLocation() == VariableDeclaration::Location::Unspecified) | ||
| for (ContractDefinition const* baseContract: _contract.annotation().linearizedBaseContracts) |
Contributor
Author
There was a problem hiding this comment.
I realized that linearizedBaseContracts is in order of the most-derived to most-base.
The last storage variable of the most-derived is the one which is closer to the end of storage.
Comment on lines
+219
to
+220
| !stateVariable->isConstant() && | ||
| !stateVariable->immutable() |
Contributor
Author
There was a problem hiding this comment.
Also need this to filter constants and immutables which are stored directly in the bytecode.
matheusaaguiar
force-pushed
the
fix_custom_storage_layout_warning_UB
branch
from
263706a to
842b794
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #16681 and #16678.